[stable31] fix(comments): mark comments as read and dismiss notifications in Activity sidebar #60621
Open
miaulalala wants to merge 1 commit into
Open
[stable31] fix(comments): mark comments as read and dismiss notifications in Activity sidebar #60621miaulalala wants to merge 1 commit into
miaulalala wants to merge 1 commit into
Conversation
miaulalala
changed the title
miaulalala
added
bug
3. to review
miaulalala
requested review from
a team,
Altahrim,
ArtificialOwl,
provokateurin and
salmart-dev
and removed request for
a team
janepie
approved these changes
May 20, 2026
AndyScherzinger
approved these changes
May 20, 2026
miaulalala
force-pushed
the
backport/60617/stable31
branch
from
0b26bd8 to
6b1affb
Compare
…hen viewed in activity sidebar Backport of #60617 for stable31. When comments are loaded via the Activity sidebar integration, call markCommentsAsRead() so the file-row unread comment bubble clears after viewing. Also add a DELETE /notifications/{id} endpoint and call it for each comment that mentions the current user so the notification bell clears without navigating via the notification link. Fixes: nextcloud/activity#2531 AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
janepie
force-pushed
the
backport/60617/stable31
branch
from
6b1affb to
f8640a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #60617 to stable31.
Summary
markCommentsAsRead()and mention notification dismissal were never called in this code pathDELETE /notifications/{id}endpoint to dismiss individual mention notifications by comment IDTest plan
🤖 Generated with Claude Code